Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.47.2 #4576

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Release 1.47.2 #4576

merged 2 commits into from
Nov 28, 2024

Conversation

katspaugh
Copy link
Member

  • Fix: catch error in hash calculation

Copy link

github-actions bot commented Nov 28, 2024

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1013.01 KB (🟢 -23.58 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Forty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -1 B) 1013.5 KB
/403 577 B (🟢 -16 B) 1013.57 KB
/404 698 B (🟢 -4 B) 1013.69 KB
/_error 228 B (🟢 -10 B) 1013.23 KB
/_offline 1.1 KB (🟡 +32 B) 1014.1 KB
/addOwner 534 B (🟢 -19 B) 1013.53 KB
/address-book 26.09 KB (🟡 +448 B) 1.01 MB
/apps 48.48 KB (🟡 +8.56 KB) 1.04 MB
/apps/bookmarked 445 B (🟢 -17 B) 1013.44 KB
/apps/custom 40.07 KB (🟡 +2.1 KB) 1.03 MB
/apps/open 55.36 KB (🟡 +17 B) 1.04 MB
/balances 38.26 KB (🟡 +723 B) 1.03 MB
/balances/nfts 19.2 KB (🟡 +1.68 KB) 1.01 MB
/cookie 8.74 KB (🟢 -7 B) 1021.74 KB
/home 59.52 KB (🟡 +1.3 KB) 1.05 MB
/imprint 1.36 KB (🟢 -28 B) 1014.37 KB
/licenses 4.98 KB (🟡 +25 B) 1017.98 KB
/new-safe/advanced-create 36.77 KB (🟡 +56 B) 1.03 MB
/new-safe/create 36.03 KB (🟡 +221 B) 1.02 MB
/new-safe/load 16.61 KB (🟡 +307 B) 1.01 MB
/privacy 14.02 KB (🟢 -14 B) 1 MB
/settings 451 B (🟢 -14 B) 1013.45 KB
/settings/appearance 8.06 KB (🟡 +354 B) 1021.06 KB
/settings/cookies 7.68 KB (🟡 +362 B) 1020.69 KB
/settings/data 7.58 KB (🟡 +365 B) 1020.58 KB
/settings/environment-variables 9.17 KB (🟡 +396 B) 1022.18 KB
/settings/modules 9.84 KB (🟡 +376 B) 1022.85 KB
/settings/notifications 27.05 KB (🟡 +235 B) 1.02 MB
/settings/safe-apps 23.94 KB (🟡 +444 B) 1.01 MB
/settings/security 8.1 KB (🟡 +367 B) 1021.11 KB
/settings/setup 47.01 KB (🟡 +767 B) 1.04 MB
/share/safe-app 9.73 KB (🟡 +409 B) 1022.73 KB
/stake 596 B (🟢 -26 B) 1013.59 KB
/swap 733 B (🟢 -21 B) 1013.72 KB
/terms 559 B (🟢 -19 B) 1013.55 KB
/transactions 73.87 KB (🟢 -13.73 KB) 1.06 MB
/transactions/history 73.84 KB (🟢 -13.72 KB) 1.06 MB
/transactions/messages 39.5 KB (🟡 +266 B) 1.03 MB
/transactions/msg 29.84 KB (🟢 -32 B) 1.02 MB
/transactions/queue 31.49 KB (🟡 +282 B) 1.02 MB
/transactions/tx 21.27 KB (🟢 -44 B) 1.01 MB
/wc 687 B (🟢 -15 B) 1013.68 KB
/welcome 6.8 KB (🟢 -12 B) 1019.81 KB
/welcome/accounts 379 B (🟢 -22 B) 1013.38 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.33% (-0.01% 🔻)
14060/18916
🔴 Branches
52.68% (+0.01% 🔼)
3485/6616
🔴 Functions 58.1% 2055/3537
🟡 Lines
75.95% (-0.01% 🔻)
12770/16813
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
87.5% (-6.79% 🔻)
80% (+3.81% 🔼)
66.67%
88.89% (-7.99% 🔻)

Test suite run success

1619 tests passing in 217 suites.

Report generated by 🧪jest coverage report action from e477fd8

@liliya-soroka
Copy link
Member

green light from the QA

@katspaugh katspaugh merged commit e477fd8 into main Nov 28, 2024
18 of 20 checks passed
@katspaugh katspaugh deleted the release branch November 28, 2024 09:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants