Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prefix switch for receive QR #2795

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix: prefix switch for receive QR #2795

merged 1 commit into from
Nov 13, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Adds a prefix switch for the QR code.

Screenshot 2023-11-13 at 13 22 57

Copy link

github-actions bot commented Nov 13, 2023

Branch preview

✅ Deploy successful!

https://fix_qr--walletweb.review-wallet-web.5afe.dev

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.03% (-0.01% 🔻)
10108/13472
🔴 Branches 49.52% 2054/4148
🔴 Functions
57.54% (-0.02% 🔻)
1500/2607
🟡 Lines
76.59% (-0.01% 🔻)
9143/11937
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / NoAssets.tsx
53.85% 0% 0% 58.33%

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 49ee193

@liliya-soroka
Copy link
Member

Verified

@katspaugh katspaugh merged commit f3fc362 into release1220 Nov 13, 2023
9 of 11 checks passed
@katspaugh katspaugh deleted the fix-qr branch November 13, 2023 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
@francovenica
Copy link
Contributor

@katspaugh @liliya-soroka There is a small issue actually. Is not in sync with the settings:

prefix toggle

@katspaugh
Copy link
Member Author

@francovenica I've seen that too. The same goes for the other QR modal. The checkbox is independent from the "main" prefix settting. I'll fix it in another PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants