Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide suspicious filter does not work beyond first page of transaction history #4005

Open
jmealy opened this issue Jul 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jmealy
Copy link
Contributor

jmealy commented Jul 29, 2024

Bug description

When you have loaded more than one page of the transaction history, toggling the hide suspicious button will only update the first page of results.

If you only load the first page, apply the filter, and then load more pages, it works as expected.

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Find a safe with suspicious transactions on the first page and on any other page.
  2. Toggle the hide suspicious filter. The first page of results will be updated.
  3. Load more pages of results. They will be loaded according to the current position of the toggle is.
  4. Once more pages are loaded, try to apply the toggle again.

Expected result

Transactions should be updated according to the current value of the hide suspicious toggle, no matter what page they are on.

Obtained result

Transactions beyond page 1 are not updated.

@liliya-soroka
Copy link
Member

existing 18.11.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: New issues
Development

No branches or pull requests

2 participants