Order imports alphabetically #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
force-pushed
the
refactor/imports-order
branch
from
c1c7b0b
to
873e316
Compare
|
@andreivladbrg lmk if imports look good with this. |
andreivladbrg
approved these changes
Mar 7, 2024
andreivladbrg
added a commit
that referenced
this pull request
Mar 11, 2024
* feat: implement SablierV2MerkleLockupLT contract feat: add createMerkleLockupLT in SablierV2MerkleLockupFactory contract * build: include Tranched contracts in prepare-artifacts * chore: use plural for tranches percantages docs: add requirements in createMerkleLockupLT natspec chore: improve wording in explanatory comments * fix: handle the case when protocol fee is greater than zero test: add Merkle Lockup LT integration tests * refactor: rename variables test: add fork tests for Merkle Lockup LT * test: remove unused import test: use pragma >=0.8.22 * chore: add named arg in custom error test: createMerkleLockupLT in factory test: update Precompiles bytecode * refactor: use plural in getter function test: getTranchesWithPercentages function test: update Precompiles bytecode * feat: add CreateMerkleLockupLT in script refactor: use maxCount in DeployProtocol script * test: add LT fork tests for USDC and USDT * ci: add fork tests to ci with 20 runs * refactor: order imports alphabetically (#301) * refactor: remove protocol fee handle in _calculateTranches build: bump core test: dry-fy fork tests test: remove protocol fee tests in claim test: add headers in MerkleLockup test: emit the correct element in the assertEq test: * refactor: remove getTranchesWithPercentages test * refactor: rename struct variable to unlockPercentage chore: improve explanatory comments test: fix fork test for MerkleLockupLT * build: update lockfile * docs: add unlock with percentages in Lockup Tranche test: remove protocol feee branch from claim.tree * refactor: rename variable to totalPercentage * test: increase coverage by testing when there is a rounding error in tranches' amounts calculation * test: improve rounding error test in claim * chore: be more precise in explanatory comment --------- Co-authored-by: smol-ninja <[email protected]>
|
I created a feature request for this in the Solhint repository: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.