Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add tranched batches #300

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Feat/add tranched batches #300

merged 4 commits into from
Mar 11, 2024

Conversation

andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented Mar 7, 2024

Closes #299

Note:

This PR also upgrades the core module to a version that no longer has the protocol fee - thus some updates here were needed as well.

test: lockup tranched batch functions
refactor: remove protocol fee and comptroller
test: update Precompiles bytecode
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good except for the comments below.

test/Base.t.sol Outdated Show resolved Hide resolved
test/Base.t.sol Outdated Show resolved Hide resolved
@andreivladbrg
Copy link
Member Author

Thanks for the review. I just removed the unused functions.

@andreivladbrg andreivladbrg merged commit 65a51db into staging Mar 11, 2024
6 of 7 checks passed
@smol-ninja smol-ninja deleted the feat/add-tranched-batches branch March 11, 2024 16:55
@andreivladbrg andreivladbrg mentioned this pull request Jul 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants