Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] s3gw / rgw+sfs upgrade path testing #835

Open
irq0 opened this issue Nov 23, 2023 · 0 comments
Open

[FR] s3gw / rgw+sfs upgrade path testing #835

irq0 opened this issue Nov 23, 2023 · 0 comments
Labels
area/CI Continuous Integration area/rgw-sfs RGW & SFS related kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API severity/normal Regular issue, some non-major loss of functionality under specific circumstances triage/next-candidate This could be moved to the next milestone

Comments

@irq0
Copy link
Contributor

irq0 commented Nov 23, 2023

Problem Statement

Moving sfs forward requires us to change the database and directory data store layout occasionally.
We already have a mechanism to version the database, run migration code and mark incompatible versions.

What we don't have is automated testing that runs a current version (e.g PR, nightly, etc) with a previous data store version that it claims to support. Due to this migration bugs and unintended incompatibilities went into main and releases.

Possible Solution

As part of every PR CI run start s3gw with the latest released version and run basic functional tests.

A possible implementation would be:
During PR CI start s3gw:latest with a named docker volume.
Then start s3gw:PR with that named volume.
Starts ok?
If so, run basic functional test

An alternative would be to create golden images of the data store with well defined content (buckets, objects, users) and make that available to the CI process.
During PR CI we could try to start with that image and property check it via S3
@github-project-automation github-project-automation bot moved this to Backlog in S3GW Nov 23, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Nov 23, 2023
@irq0 irq0 added kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API area/rgw-sfs RGW & SFS related area/CI Continuous Integration severity/normal Regular issue, some non-major loss of functionality under specific circumstances and removed triage/waiting Waiting for triage labels Nov 23, 2023
@jecluis jecluis added the priority/0 Needs to go into the next release or force a patch label Nov 26, 2023
@jecluis jecluis added this to the v0.24.0 milestone Nov 26, 2023
@jecluis jecluis added triage/next-candidate This could be moved to the next milestone and removed priority/0 Needs to go into the next release or force a patch labels Mar 21, 2024
@jecluis jecluis added this to s3gw Mar 21, 2024
@jecluis jecluis moved this to Backlog in s3gw Mar 21, 2024
@jecluis jecluis removed this from the v0.24.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/CI Continuous Integration area/rgw-sfs RGW & SFS related kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API severity/normal Regular issue, some non-major loss of functionality under specific circumstances triage/next-candidate This could be moved to the next milestone
Projects
s3gw
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jecluis @irq0 @Ameenasuhani