Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw/sfs: refactor of SFSBucket::merge_and_store_attrs() #798

Closed
giubacc opened this issue Nov 13, 2023 · 0 comments · Fixed by aquarist-labs/ceph#244
Closed

rgw/sfs: refactor of SFSBucket::merge_and_store_attrs() #798

giubacc opened this issue Nov 13, 2023 · 0 comments · Fixed by aquarist-labs/ceph#244
Assignees
@giubacc
Labels
area/rgw-sfs RGW & SFS related kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API priority/1 Should be fixed for next release
Milestone
v0.23.0

Comments

@giubacc
Copy link

giubacc commented Nov 13, 2023

What needs to be done

https://github.com/aquarist-labs/s3gw/issues/750 highlighted an overcomplicated implementation of SFSBucket::merge_and_store_attrs().
We will provide a better implementation of that.
@github-project-automation github-project-automation bot moved this to Backlog in S3GW Nov 13, 2023
@giubacc giubacc self-assigned this Nov 13, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Nov 13, 2023
@giubacc giubacc added area/rgw-sfs RGW & SFS related kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API and removed triage/waiting Waiting for triage labels Nov 13, 2023
@giubacc giubacc moved this from Backlog to In Progress 🏗️ in S3GW Nov 13, 2023
@giubacc giubacc added this to the v0.23.0 milestone Nov 13, 2023
giubacc referenced this issue in giubacc/ceph Nov 13, 2023
rgw/sfs: refactor of SFSBucket::merge_and_store_attrs()
965045d 
Refactored with a set_and_store_attrs semantics.
The previous implementation was started as if the method should implement a merge but the actual usage suggests set semantics.
The new implementation is more concise and simplified.

Fixes: https://github.com/aquarist-labs/s3gw/issues/798
Signed-off-by: Giuseppe Baccini <[email protected]>
@giubacc giubacc mentioned this issue Nov 13, 2023
Merged
11 tasks
giubacc referenced this issue in giubacc/ceph Nov 14, 2023
rgw/sfs: refactor of SFSBucket::merge_and_store_attrs()
a1d138d 
Refactored with a set_and_store_attrs semantics.
The previous implementation was started as if the method should implement a merge but the actual usage suggests set semantics.
The new implementation is more concise and simplified.

Fixes: https://github.com/aquarist-labs/s3gw/issues/798
Signed-off-by: Giuseppe Baccini <[email protected]>
giubacc referenced this issue in giubacc/ceph Nov 14, 2023
rgw/sfs: refactor of SFSBucket::merge_and_store_attrs()
5fb9ecd 
Refactored with an "overwrite" semantics.
The previous implementation was started as if the method should implement a merge but the actual usage suggests "overwrite" semantics.
The new implementation is more concise and simplified.

Fixes: https://github.com/aquarist-labs/s3gw/issues/798
Signed-off-by: Giuseppe Baccini <[email protected]>
@vmoutoussamy vmoutoussamy added the priority/1 Should be fixed for next release label Nov 15, 2023
giubacc referenced this issue in giubacc/ceph Nov 17, 2023
rgw/sfs: refactor of SFSBucket::merge_and_store_attrs()
6f4a16a 
Refactored with an "overwrite" semantics.
The previous implementation was started as if the method should implement a merge but the actual usage suggests "overwrite" semantics.
The new implementation is more concise and simplified.

Fixes: https://github.com/aquarist-labs/s3gw/issues/798
Signed-off-by: Giuseppe Baccini <[email protected]>
giubacc referenced this issue in giubacc/ceph Nov 17, 2023
rgw/sfs: refactor of SFSBucket::merge_and_store_attrs()
dcf6a24 
Refactored with an "overwrite" semantics.
The previous implementation was started as if the method should implement a merge but the actual usage suggests "overwrite" semantics.
The new implementation is more concise and simplified.

Fixes: https://github.com/aquarist-labs/s3gw/issues/798
Signed-off-by: Giuseppe Baccini <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done in S3GW Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giubacc giubacc

Labels
area/rgw-sfs RGW & SFS related kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API priority/1 Should be fixed for next release
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging a pull request may close this issue.

rgw/sfs: refactor of SFSBucket::merge_and_store_attrs() giubacc/ceph
2 participants
@vmoutoussamy @giubacc