Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Instance Identification #765

Closed
m-ildefons opened this issue Oct 20, 2023 · 1 comment · Fixed by s3gw-tech/s3gw-ui#286
Closed

UI: Instance Identification #765

m-ildefons opened this issue Oct 20, 2023 · 1 comment · Fixed by s3gw-tech/s3gw-ui#286
Assignees
@votdev
Labels
area/ui User Interface kind/feature New functionality or support for something priority/1 Should be fixed for next release
Milestone
v0.23.0

Comments

@m-ildefons
Copy link
Contributor

In cases where multiple instances of the s3gw are deployed in the same Longhorn cluster, it would be beneficial to have a clearly visible instance identification in the UI. The instance ID can be injected from e.g. an environment variable at deploy time and should be displayed on the landing/login page as well as the title bar.
At the moment there is no way other than the URL path to differentiate between multiple instances of the s3gw making multi-instance deployments confusing.
@m-ildefons m-ildefons added priority/1 Should be fixed for next release area/ui User Interface kind/feature New functionality or support for something LH 1.6 labels Oct 20, 2023
@m-ildefons m-ildefons added this to the v0.23.0 milestone Oct 20, 2023
@m-ildefons m-ildefons added this to S3GW Oct 20, 2023
@github-project-automation github-project-automation bot moved this to Backlog in S3GW Oct 20, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Oct 20, 2023
@jecluis
Copy link
Contributor

jecluis commented Oct 22, 2023

This can be either a specific env variable with an instance id, like the object store name in the LH case, or we can start by reusing the already provided S3GW_SERVICE_URL and showing that somewhere in the UI. I lean towards the former, and default to the latter if an id is not provided.

@jecluis jecluis removed the triage/waiting Waiting for triage label Oct 22, 2023
votdev referenced this issue in votdev/s3gw-ui Nov 15, 2023
@votdev
Instance Identification
b731db2 
Fixes: https://github.com/aquarist-labs/s3gw/issues/765

Signed-off-by: Volker Theile <[email protected]>
@votdev votdev mentioned this issue Nov 15, 2023
Merged
votdev referenced this issue in votdev/s3gw-ui Nov 15, 2023
@votdev
Instance Identification
facd3c7 
Fixes: https://github.com/aquarist-labs/s3gw/issues/765

Signed-off-by: Volker Theile <[email protected]>
votdev referenced this issue in votdev/s3gw-ui Nov 16, 2023
@votdev
Instance Identification
6472f7d 
Additional changes:
- Relocate logging initialization. This way logger calls done by our code will be logged as well.

Fixes: https://github.com/aquarist-labs/s3gw/issues/765

Signed-off-by: Volker Theile <[email protected]>
votdev referenced this issue in votdev/s3gw-ui Nov 17, 2023
@votdev
Instance Identification
5bb604d 
Additional changes:
- Relocate logging initialization. This way logger calls done by our code will be logged as well.

Fixes: https://github.com/aquarist-labs/s3gw/issues/765

Signed-off-by: Volker Theile <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Done in S3GW Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@votdev votdev

Labels
area/ui User Interface kind/feature New functionality or support for something priority/1 Should be fixed for next release
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging a pull request may close this issue.

Instance Identification votdev/s3gw-ui
3 participants
@jecluis @votdev @m-ildefons