Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA: ensure s3gw backend image is preloaded on every k8s node #734

Closed
giubacc opened this issue Oct 2, 2023 · 3 comments
Closed

HA: ensure s3gw backend image is preloaded on every k8s node #734

giubacc opened this issue Oct 2, 2023 · 3 comments
Labels
area/kubernetes k8s and related

Comments

@giubacc
Copy link

giubacc commented Oct 2, 2023

What needs to be done

We need to ensure that the s3gw backend image is preloaded on every k8s node.
Failing to guarantee this implies that if the s3gw is scheduled to load on a node where the s3gw image is not cached, the system should pay the time needed to download the image from the registry before starting it.
In general on Kubernetes, it can not be assumed that an image is pre-pulled, since nodes may come and go dynamically.
Pre-pulled images is something we do want to ensure for eligible nodes. Otherwise, our restart is unpredictably long.
It's always possible that a fault occurs exactly at the time where we are pre-loading the image, but that's just bad luck.

Why it needs to be done

This requirement is needed by the s3gw HA model: Active/Standby.

Acceptance Criteria

Additional Information

@github-project-automation github-project-automation bot moved this to Backlog in S3GW Oct 2, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Oct 2, 2023
@giubacc giubacc changed the title Ensure s3gw backend image is preloaded on every k8s node HA: ensure s3gw backend image is preloaded on every k8s node Oct 2, 2023
@giubacc
Copy link
Author

giubacc commented Oct 4, 2023

cc @m-ildefons

@jecluis jecluis added priority/0 Needs to go into the next release or force a patch area/kubernetes k8s and related LH 1.6 and removed triage/waiting Waiting for triage labels Oct 15, 2023
@jecluis jecluis added this to the v0.23.0 milestone Oct 15, 2023
@jecluis jecluis modified the milestones: v0.23.0, v0.25.0 Oct 25, 2023
@jecluis
Copy link
Contributor

jecluis commented Oct 25, 2023

After checking with @l-mb and @m-ildefons , we believe it's better to push this to after v0.23.0. That frees @m-ildefons to focus on pushing for the initial version of LH controller without adding new requirements, and grants us time to figure out what's the best approach to deal with this.

@jecluis jecluis added priority/1 Should be fixed for next release and removed LH 1.6 priority/0 Needs to go into the next release or force a patch labels Oct 25, 2023
@jecluis jecluis removed the priority/1 Should be fixed for next release label Mar 20, 2024
@jecluis jecluis removed this from the v0.25.0 milestone Mar 20, 2024
@jecluis
Copy link
Contributor

jecluis commented Mar 20, 2024

We believe this is no longer something we should focus on.

@jecluis jecluis closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in S3GW Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes k8s and related
Projects
None yet
Development

No branches or pull requests

2 participants