Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable caching of index.html in s3gw-ui via ingress #732

Closed
votdev opened this issue Sep 29, 2023 · 1 comment
Closed

Disable caching of index.html in s3gw-ui via ingress #732

votdev opened this issue Sep 29, 2023 · 1 comment
Labels
area/kubernetes k8s and related kind/enhancement Change that positively impacts existing code triage/waiting Waiting for triage

Comments

@votdev
Copy link
Contributor

votdev commented Sep 29, 2023

The ingress we deploy for the s3gw-ui should add custom headers to disable caching of index.html. This way the file will always be loaded from the server which ensures that changes to the assets (e.g. JS files hashed by Angular) are applied. Otherwise, changes to the s3gw-ui might not be visible to the user because the SPA is not updated as it is cached by the browser.

Necessary headers for index.html:

  • Cache-Control: no-cache, max-age=0, must-revalidate
  • Expires: 0
  • Pragma: no-cache
@votdev votdev added kind/enhancement Change that positively impacts existing code area/kubernetes k8s and related labels Sep 29, 2023
@votdev votdev added this to S3GW Sep 29, 2023
@github-project-automation github-project-automation bot moved this to Backlog in S3GW Sep 29, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label Sep 29, 2023
@votdev votdev changed the title Disable caching for index.html of the s3gw-ui Disable caching of index.html in s3gw-ui Sep 29, 2023
@votdev votdev changed the title Disable caching of index.html in s3gw-ui Disable caching of index.html in s3gw-ui via ingress Sep 29, 2023
@votdev
Copy link
Contributor Author

votdev commented Sep 29, 2023

Obsolete by s3gw-tech/s3gw-ui#268 which adds the headers via FastAPI.

@votdev votdev closed this as completed Sep 29, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in S3GW Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes k8s and related kind/enhancement Change that positively impacts existing code triage/waiting Waiting for triage
Projects
None yet
Development

No branches or pull requests

1 participant