Adds stream!/3 interface
#34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmwaffles
commented
May 29, 2024
warmwaffles
commented
May 29, 2024
|
@rzane I'd like your input on this implementation thus far before I start hammering on it more. |
warmwaffles
force-pushed
the
add-stream-interface
branch
2 times, most recently
from
1d2e0c1
to
834ea25
Compare
|
@rzane I made some changes here. I still need to fix my local Minio and make sure the S3 adapter is working how I want it to. |
This is a rough draft of what I think the stream implementation should be like. I do not know how I am going to test the error case where the file can not be found with any of the adapters. The exception happens in a supervised storage implementation that is inside of a macro for the adapter cases.
warmwaffles
force-pushed
the
add-stream-interface
branch
from
834ea25
to
245c10f
Compare
|
I will come back to this soooon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough draft of what I think the stream implementation should be like. I do not know how I am going to test the error case where the file can not be found with any of the adapters. The exception happens in a supervised storage implementation that is inside of a macro for the adapter cases.
I'm looking for some feedback on this while I work through this.
Closes #33