Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test issue related to testthat 3.0 release #16

Open
rywhale opened this issue Oct 6, 2020 · 1 comment
Open

Unit test issue related to testthat 3.0 release #16

rywhale opened this issue Oct 6, 2020 · 1 comment
Labels
bug todo Priority features to implement

Comments

@rywhale
Copy link
Owner

rywhale commented Oct 6, 2020

Error in tests for ki_station_list related to testthat 3.0 release. From check in email:

----FAILURE (test_ki_station_list.R:71:3): ki_station_list accepts custom return
`stn_cust_retr` not equal to `stn_cust_retr2`
Component "station_id": 76 string mismatches
Component "station_no": 76 string mismatches
@rywhale rywhale added bug todo Priority features to implement labels Oct 6, 2020
@dimfalk
Copy link
Contributor

dimfalk commented Apr 24, 2022

Hi, I was messing around with testthat 3.0 lately and thought I'd have a look into this issue here.

In order to activate v3.0, Config/testthat/edition: 3 needs to be added to DESCRIPTION if I'm not mistaken.

As a result, devtools::test() returns the following:

Duration: 62.8 s

[ FAIL 0 | WARN 5 | SKIP 0 | PASS 55 ]

Warnings are limited to context() was deprecated in the 3rd edition - but I was not able to reproduce the bug mentioned above in test_ki_station_list.R.

Is this issue still relevant?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug todo Priority features to implement
Projects
None yet
Development

No branches or pull requests

2 participants