Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Upgrade tui.editor from version 2.5 to version 3.x #137

Closed
kiyoka opened this issue Aug 31, 2022 · 5 comments
Closed

Feature Request: Upgrade tui.editor from version 2.5 to version 3.x #137

kiyoka opened this issue Aug 31, 2022 · 5 comments

Comments

@kiyoka
Copy link
Contributor

kiyoka commented Aug 31, 2022

Reasons to upgrade

  1. Because tui.editor 2.5 has a bug, so Feature Request: Ability to easily get the full path of the image #134 cannot be implemented. tui.editor 3.2 does not have the same bug.
  1. The main focus of the tui.editor project has moved to tui.editor 3.x, so any problems in tui.editor 2.5 may not be fixed.

Required Work

  1. Follow the migration guide below.
    https://github.com/nhn/tui.editor/blob/master/docs/v3.0-migration-guide.md
    I believe it is better to actually do the work to see what kind of work will be involved.
@kiyoka
Copy link
Contributor Author

kiyoka commented Sep 5, 2022

I share the current status.
A few problems remain, but it is mostly working with tui.editor 3.0.0.

https://github.com/kiyoka/unotes/commits/fix_issue_137.tmp1

Remaining issues:

@kiyoka
Copy link
Contributor Author

kiyoka commented Sep 16, 2022

Remaining issues:

  • The tui.editor plugin interface has changed, so the katex plugin interface needs to be changed.
  • Key bindings like Ctrl + ALT + 1, Ctrl + ALT + 2, ... do not work.

@kiyoka
Copy link
Contributor Author

kiyoka commented Sep 19, 2022

Remaining issues:

  • The tui.editor plugin interface has changed, so the katex plugin interface needs to be changed.

@kiyoka
Copy link
Contributor Author

kiyoka commented Sep 21, 2022

All remaining issues have been cleared.
I will use new Unotes for a while and if I have no problem using it, I will pull request it.

kiyoka added a commit to kiyoka/unotes that referenced this issue Sep 28, 2022
Feature Request: Upgrade tui.editor from version 2.5 to version 3.x
kiyoka added a commit to kiyoka/unotes that referenced this issue Sep 29, 2022
Feature Request: Upgrade tui.editor from version 2.5 to version 3.x
ryanmcalister added a commit that referenced this issue Oct 20, 2022
Upgrade tui.editor from version 2.5 to version 3.x (#137)
@ryanmcalister
Copy link
Owner

I'm going to close this since it's been released in v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants