Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename loadContext to Context? #56

Open
zackify opened this issue Mar 11, 2016 · 3 comments
Open

Rename loadContext to Context? #56

zackify opened this issue Mar 11, 2016 · 3 comments

Comments

@zackify
Copy link

zackify commented Mar 11, 2016

It feels weird doing loadContext.user wouldn't it make more sense if it was just context.user?
@ryanflorence
Copy link
Owner

Don't want to confuse it with react's context.

@ryanflorence
Copy link
Owner

But ... yeah I could pretty easily be persuaded to just call it context.

@zackify
Copy link
Author

zackify commented Mar 11, 2016

I think it's pretty clear that it's not from react since you have to pass it in to loadPropsOnServer. It feels so weird accessing it this way haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryanflorence @zackify and others