You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RDKit changed it's behavior to display coordination of metal ions (e.g. carboxylate cations). As this includes a "->", it is incompatible with rxnmappers splitting of the reaction at ">" (see here).
While likely the "->" is not in the vocab (and thus not compatible with the current model version), you could just check for the sign and replace it with an empty string, to stay compatible with the sanitization.
Additionally, it could make sense to use rdkits rxn.GetReactants(), rxn.GetAgents() and rxn.GetProducts() function instead of the string splitting.
Just wanted to make you aware of this issue.
Best
Frederik
Thanks for reporting this. Such reaction SMILES should now work with the new version of rxn-chemutils (see change in rxn4chemistry/rxn-chemutils#30). In #53, I added a test to confirm.
Note that although it technically works, the current model was not trained on a single reaction containing such dative bonds :)
RDKit changed it's behavior to display coordination of metal ions (e.g. carboxylate cations). As this includes a "->", it is incompatible with rxnmappers splitting of the reaction at ">" (see here).
Example for Reaction sanitization:
Example for molecule sanitization:
While likely the "->" is not in the vocab (and thus not compatible with the current model version), you could just check for the sign and replace it with an empty string, to stay compatible with the sanitization.
Additionally, it could make sense to use rdkits
rxn.GetReactants()
,rxn.GetAgents()
andrxn.GetProducts()
function instead of the string splitting.Just wanted to make you aware of this issue.
Best
Frederik
@avaucher
The text was updated successfully, but these errors were encountered: