Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lineBuff and dbuff of DebugDraw can be converted to std::optional #654

Open
ghost opened this issue Nov 2, 2018 · 2 comments
Open

lineBuff and dbuff of DebugDraw can be converted to std::optional #654

ghost opened this issue Nov 2, 2018 · 2 comments
Labels
cleanup easy enhancement

Comments

@ghost
Copy link

ghost commented Nov 2, 2018

It should be quite simple task, but replacing usages can require some work.
@ArtemPopof
Copy link
Contributor

What is a purpose of this changes?

@ghost
Copy link
Author

ghost commented Feb 13, 2019

They are not moved even once, when engine is running. So it's better to use static allocated memory and improve caching.

Also operating on objects is nicer than on ptrs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup easy enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ArtemPopof