Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server_key_algorithms test flaky? #37

Open
cpu opened this issue Jun 28, 2024 · 1 comment
Open

server_key_algorithms test flaky? #37

cpu opened this issue Jun 28, 2024 · 1 comment

Comments

@cpu
Copy link
Member

cpu commented Jun 28, 2024

Noticed a failure on main that was resolved after a retry:

thread 'server_key_algorithms' panicked at tests/runner.rs:807:9:
assertion `left == right` failed: stdout EOF -- read so far []
  left: 0
 right: 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Archived build log: logs_25438992097.zip

@cpu cpu self-assigned this Jun 28, 2024
@cpu
Copy link
Member Author

cpu commented Jul 3, 2024

I'm able to reproduce this locally running the test in a loop (example script), but it's fairly rare. My most recent failure happened after 450 test runs. After staring at the code for a while I'm pretty stumped.

It seems like when the test fails it's because reading the pipe created by Command::new(...).stdout(Stdio::piped()) to run target/server is returning 0 on the very first iteration of wait_for_stdout, in the first call to stream.stdout().as_mut().unwrap().read(&mut input).unwrap(). I'm not sure how that could happen 🤔 Maybe dumping stderr when it does would give some hint?

@cpu cpu removed their assignment Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant