From ce84ad7f67e42e768025957e98bf99525e4f83fa Mon Sep 17 00:00:00 2001 From: Daniel McCarney Date: Wed, 27 Nov 2024 16:26:27 -0500 Subject: [PATCH] proj: MSRV 1.71 -> 1.73 1.71 and 1.72 both hit an ICE building with a static reference to Rustls' aws-lc-rs HPKE suites. Upstream (sensibly) isn't interested in fixing bugs in old compilers. We also don't want to bump the upstream Rustls MSRV for niche errors, or add excessive workarounds. So: let's do the easy thing and increase rustls-ffi's MSRV to 1.73. The rustls-ffi project has few downstream consumers at this point and so is more agile for MSRV bumps than the core crate. Along the way, match the formatter to the MSRV. It had fallen behind. --- .github/workflows/test.yaml | 4 ++-- README.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 7b11d03f..75e3e76c 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -25,7 +25,7 @@ jobs: - nightly # MSRV - keep in sync with what rustls and rustls-platform-verifier # consider MSRV - - "1.71" + - "1.73" os: [ ubuntu-latest ] # Include a few MacOS and cert-compression builds to ensure they're tested without # bloating the matrix or slowing down CI. @@ -310,7 +310,7 @@ jobs: - name: Install rust toolchain uses: dtolnay/rust-toolchain@master with: - toolchain: "1.71" + toolchain: "1.73" # Matching MSRV components: rustfmt - name: Install Gersemi diff --git a/README.md b/README.md index f2ab5a2d..0f4f9ff2 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ to provide the cryptographic primitives. # Build rustls-ffi To build rustls-ffi as a static or shared library you'll need to [install the -Rust toolchain](https://rustup.rs/) (version 1.71 or above) as well as +Rust toolchain](https://rustup.rs/) (version 1.73 or above) as well as [cargo-c]. The [cargo-c] tool can be installed from