Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit actix-web #39

Open
Shnatsel opened this issue Sep 8, 2019 · 1 comment
Open

Audit actix-web #39

Shnatsel opened this issue Sep 8, 2019 · 1 comment

Comments

@Shnatsel
Copy link
Member

Shnatsel commented Sep 8, 2019

https://crates.io/crates/actix-web

High-profile Rust web framework, perhaps the most popular one. Contains some potentially unnecessary unsafe code.

Actix-web has already gotten plenty of bad publicity (including very recently) for judicious use of unsafe code, which made it a sensitive topic to the author. Please be respectful when talking to maintainers. When opening a PR, provide benchmark results before and after the proposed change.
@Shnatsel
Copy link
Member Author

Shnatsel commented Sep 8, 2019 •
edited
Loading

Undefined behavior in safe code described here does not apply to actix-web: it's in actix-net crate, which is not in the dependency tree of actix-web. Still needs to be fixed though.

Actually it applies, more info here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shnatsel