Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --build-plan #45

Open
ehuss opened this issue Sep 26, 2019 · 1 comment
Open

Support --build-plan #45

ehuss opened this issue Sep 26, 2019 · 1 comment
Labels
implementation Implementation exploration and tracking issues

Comments

@ehuss
Copy link
Contributor

ehuss commented Sep 26, 2019

The --build-plan flag mostly works, but it does not capture the way the artifacts are copied to the sysroot as of rust-lang/cargo#7421. It also needs some tests, and probably some careful review.

It may be possible to just add the sysroot artifacts to the "links" list? That may be difficult to modify that list, though, as it currently uses a different mechanism to hard link the files.

Another possibility is to change the way Cargo hard links the sysroot artifacts. It is currently implemented in an unusual way in order to support pipelining between the last sysroot crate and the user's crate. This may not be a substantial benefit, so if pipelining was disabled between standard lib to the user's crate, a different approach may be taken (possibly as an OutputFile::hardlink?).

I'm also a bit uncertain about the future of build-plan in general.

@ehuss ehuss added the implementation Implementation exploration and tracking issues label Sep 26, 2019
@Ericson2314
Copy link

rust-lang/cargo#7614 Looks like --build-plan is out so this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Implementation exploration and tracking issues
Projects
None yet
Development

No branches or pull requests

2 participants