Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find some way to work around github not running CI on GHA-created PRs #1864

Closed
RalfJung opened this issue Dec 5, 2024 · 4 comments · Fixed by #1866
Closed

Find some way to work around github not running CI on GHA-created PRs #1864

RalfJung opened this issue Dec 5, 2024 · 4 comments · Fixed by #1866

Comments

@RalfJung
Copy link
Member

RalfJung commented Dec 5, 2024

PRs created in GHA do not trigger CI. That is a problem when combined with merge queues, where a PR will only be considered ready-to-land when CI passes. The best work-around I know of so far is to close and re-open the PR, which will trigger CI.

It might make sense to have a bot do the close-and-reopen automatically, just so that CI has generally already run by the time a human looks at the PR.

@RalfJung
Copy link
Member Author

RalfJung commented Dec 9, 2024

Thanks!

Do we need to configure something to enable this in Miri, or should it "Just Work (TM)"?

@Mark-Simulacrum
Copy link
Member

You'll need to add the empty table to config.toml, the newly added forge docs should have an example.

@RalfJung
Copy link
Member Author

Unfortunately this does not seem to work yet: rust-lang/miri#4085.

FWIW another possible modus operandi here might be for the PR description itself to contain @rustbot reopen as a signal to please close and reopen the PR.

@RalfJung
Copy link
Member Author

In rust-lang/miri#4088 it worked, amazing :) Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants