Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup-init.sh: unknown macOS major version #4119

Open
harry-xm opened this issue Dec 19, 2024 · 1 comment
Open

rustup-init.sh: unknown macOS major version #4119

harry-xm opened this issue Dec 19, 2024 · 1 comment

Comments

@harry-xm
Copy link

In check_help_for(), there is a branch for macOS that treats all versions newer than Big Sur as "unknown macOS major version."

Normally this branch is not executed, but before commit a9c4362 there was a brief period where it could be reached when curl is too new.

Is the check still necessary?

rustup/rustup-init.sh

Lines 732 to 739 in dc9d072

11.*)
# We assume Big Sur will be OK for now
;;
*)
# Unknown product version, warn and continue
warn "Detected unknown macOS major version: $(sw_vers -productVersion)"
warn "TLS capabilities detection may fail"
;;

By the way, : is missing on the last line of warn, which is inconsistent and might worth fixing.

@rami3l
Copy link
Member

rami3l commented Dec 20, 2024

@harry-xm Thanks for reporting this! Indeed this part of the script has been out of date since quite a while ago.

I think it shouldn't be too hard to change 11.* to something like "anything >= 11", maybe by issuing sw_vers -productVersion | cut -d. -f1 in the *) branch?

PS: I can find some time to fix this, and in the meantime please feel free to send a PR over if you like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants