Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider introducing an HTML and CSS formatter for the Rustup website #4091

Open
Rustin170506 opened this issue Nov 19, 2024 · 2 comments
Open

Comments

@Rustin170506
Copy link
Member

Problem you are trying to solve

As dicsusued in #4080 (comment) and #4080 (comment).

I think it would be a good idea to introduce a formatter for this. It would help us avoid similar situations in the future. I’d recommend using Prettier, but it does require adding a new toolchain, such as npm, pnpm, or yarn, to install it. What are your thoughts on this?

Solution you'd like

  1. Install the prettier
  2. Format the project using the default configuration.

Notes

No response

@djc
Copy link
Contributor

djc commented Nov 19, 2024

I think it would be a good idea to introduce a formatter for this. It would help us avoid similar situations in the future. I’d recommend using Prettier, but it does require adding a new toolchain, such as npm, pnpm, or yarn, to install it. What are your thoughts on this?

I think the most important factor is that we can easily deploy something into CI. Beyond that, having plugins for common editors (like VS Code) might be a nice to have. I don't have a good sense of the landscape here, Prettier seems okay to me.

@rami3l
Copy link
Member

rami3l commented Nov 30, 2024

@djc Yup, I agree with prettier as well, since it has a pretty sane default config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants