Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic while formatting doc comment with nested block quotations #6427

Open
scouten-adobe opened this issue Dec 30, 2024 · 5 comments
Open

Panic while formatting doc comment with nested block quotations #6427

scouten-adobe opened this issue Dec 30, 2024 · 5 comments
Labels
a-comments needs-mcve needs a Minimal Complete and Verifiable Example

Comments

@scouten-adobe
Copy link

scouten-adobe commented Dec 30, 2024

Nightly build of rustfmt panics while formatting code with nested block quotation sections.

Test case, including rustc-ice log file is available here: contentauth/c2pa-rs#808. The last commit in that PR introduces changes that cause the panic.

@scouten-adobe
Copy link
Author

I'll close the PR on our end since we can't merge it as is, but leave it available for your team to inspect.

scouten-adobe added a commit to contentauth/c2pa-rs that referenced this issue Dec 30, 2024
@scouten-adobe
Copy link
Author

Removing the nested block quote (as I did in contentauth/c2pa-rs@9bd8350) seems to avoid the issue.

This is not a blocker for us; providing the bug report as an FYI.

@ytmimi
Copy link
Contributor

ytmimi commented Dec 30, 2024

@scouten-adobe what version of rustfmt were you running (can you run rustfmt --version), and what configurations are you using?

Also, it would be very helpful if you could post a minimal reproduction here instead of linking to a PR.

@scouten-adobe
Copy link
Author

$ cargo +nightly fmt --version
rustfmt 1.8.0-nightly (14ee63a3c6 2024-12-29)

@ytmimi I'm on critical path for some other tasks, so I can't really take time to create a minimal repro. As I said, this is not a blocker for us.

@ytmimi
Copy link
Contributor

ytmimi commented Dec 30, 2024

It doesn't have to be right now, but if you could revisit this again when you have some time that would help.

@ytmimi ytmimi added the needs-mcve needs a Minimal Complete and Verifiable Example label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-comments needs-mcve needs a Minimal Complete and Verifiable Example
Projects
None yet
Development

No branches or pull requests

2 participants