Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging for tracing #892

Closed
ehuss opened this issue Sep 25, 2020 · 4 comments · Fixed by #997
Closed

Update logging for tracing #892

ehuss opened this issue Sep 25, 2020 · 4 comments · Fixed by #997
Assignees

Comments

@ehuss
Copy link
Contributor

ehuss commented Sep 25, 2020

It looks like the compiler moved to the tracing crate. I think at a minimum, the section at https://rustc-dev-guide.rust-lang.org/compiler-debugging.html?highlight=log#getting-logging-output should be updated to mention that.

I don't actually know why it was changed, what the differences are, or what the motivation was. rust-lang/compiler-team#331 and rust-lang/rust#74726 don't really say. Is there anything I need to know about the differences? Are there any examples of when using spans or #[instrument] would be useful? Should messages use structured fields (and how or why is that useful)?

@jyn514
Copy link
Member

jyn514 commented Sep 30, 2020

@oli-obk do you have time to work on this?

@oli-obk
Copy link
Contributor

oli-obk commented Sep 30, 2020

We are not using spans or #[instrument] yet. There are no differences in usage yet. Before we can start using awesome tracing features we'll need to benchmark them and agree on a span rendering strategy. rust-lang/rust#75143 explores span rendering, please look at it and leave opinions.

But yea, some minimal updating of the logging section would be a good thing. I'll try to find some time, but won't complain if someone grabs it

@igaray
Copy link
Member

igaray commented Sep 30, 2020

I'm currently working on the survey translations but in a few days I'll free up and could take this :) Won't claim it in case someone wants to do it right away.

@camelid
Copy link
Member

camelid commented Jan 4, 2021

I fixed this in #997.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants