Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all symbols weak? #257

Open
jonathanpallant opened this issue Oct 13, 2021 · 1 comment
Open

Make all symbols weak? #257

jonathanpallant opened this issue Oct 13, 2021 · 1 comment

Comments

@jonathanpallant
Copy link

jonathanpallant commented Oct 13, 2021

Some target devices have extra features that this library doesn't support. For example, the Raspberry Silicon RP2040 has hand-optimised floating-point routines in ROM, as well as a non-standard interpolator and integer divider IP block.

We'd like to supply optimised versions of some of the libm functions that make use of these features, but we can't because libm exports only strong symbols.

Could we change all the functions to have weak symbols, so we can push out and replace functions on a case-by-case basis without forking libm?

@Amanieu
Copy link
Member

Amanieu commented Oct 14, 2021

Sure! We already do this for the mem* functions in compiler-builtins, so it should be fine to do the same here. I would be happy to accept a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants