Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "openbsd/netbsd factorise getnameinfo." #3834

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

tgross35
Copy link
Contributor

This reverts commit 5df9fa0.

The change broke builds for OpenBSD. See discussion at #3822 (comment).

This reverts commit 5df9fa0.

The change broke builds for OpenBSD. See discussion at
<rust-lang#3822 (comment)>.
@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2024

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in OpenBSD module

cc @semarie

tgross35 added a commit to tgross35/rust-libc that referenced this pull request Aug 16, 2024
This reverts commit 66cdb6b.

The change broke builds for OpenBSD. See discussion at
<rust-lang#3822 (comment)>.

Stable version: <rust-lang#3834>.
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Aug 16, 2024
This reverts commit 66cdb6b.

The change broke builds for OpenBSD. See discussion at
<rust-lang#3822 (comment)>.

`main` version: <rust-lang#3834>.
@tgross35 tgross35 enabled auto-merge August 16, 2024 06:55
Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. the test suite pass again with it

@tgross35 tgross35 added this pull request to the merge queue Aug 16, 2024
Merged via the queue into rust-lang:main with commit 8f20f00 Aug 16, 2024
39 checks passed
@tgross35 tgross35 deleted the revert-bsd-getnameinfo branch November 17, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants