Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo install should use --cap-lints #3453

Closed
whitequark opened this issue Dec 25, 2016 · 3 comments
Closed

cargo install should use --cap-lints #3453

whitequark opened this issue Dec 25, 2016 · 3 comments
Labels
A-lints Area: rustc lint configuration Command-install

Comments

@whitequark
Copy link
Member

I was installing cargo edit today, and this is how it failed:

error: unnecessary qualification
  --> /home/whitequark/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-edit-0.1.3/src/manifest.rs:13:1
   |
13 | quick_error! {
   | ^
   |
note: lint level defined here
  --> /home/whitequark/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-edit-0.1.3/src/lib.rs:4:176
   |
4  | #![deny(missing_docs, missing_debug_implementations, missing_copy_implementations, trivial_casts, trivial_numeric_casts, unsafe_code, unstable_features, unused_import_braces, unused_qualifications)]
   |                                                                                                                                                                                ^^^^^^^^^^^^^^^^^^^^^
   = note: this error originates in a macro outside of the current crate

This seems undesirable.

@alexcrichton
Copy link
Member

Makes sense to me!

@sanmai-NL
Copy link

To clarify: info on rustc --cap-lints.

@dwijnand dwijnand self-assigned this Feb 9, 2019
@ehuss ehuss added the A-lints Area: rustc lint configuration label Feb 21, 2019
@dwijnand dwijnand removed their assignment Feb 25, 2019
@dwijnand
Copy link
Member

Fixed as of ~1.15 (perhaps in #3221).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lints Area: rustc lint configuration Command-install
Projects
None yet
Development

No branches or pull requests

5 participants