Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple FormatOptions from Snippet #40

Closed
epage opened this issue Nov 23, 2020 · 4 comments
Closed

Decouple FormatOptions from Snippet #40

epage opened this issue Nov 23, 2020 · 4 comments

Comments

@epage
Copy link
Contributor

epage commented Nov 23, 2020

At the layer I want to be creating Snippets, I won't know whether colored formatting is appropriate or not. That seems like a concern for when converting into a DisplayList.

@epage
Copy link
Contributor Author

epage commented Nov 23, 2020

I can work around this by mutating the fields but in general, it doesn't seem to be separating concerns appropriately.

@zbraniecki
Copy link
Contributor

The way you construct the Snippet is flexible, and all that matters is that in the end you pass the right data to building Display List.

Maybe what you're reporting here is that FormatOptions are not a property of Snippet and instead should be separate and passed together into DisplayList builder?

@epage
Copy link
Contributor Author

epage commented Nov 23, 2020

Maybe what you're reporting here is that FormatOptions are not a property of Snippet and instead should be separate and passed together into DisplayList builder?

Yes, separating styling from semantic information.

@epage
Copy link
Contributor Author

epage commented Dec 5, 2023

Closed via #67

@epage epage closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants