Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAN FD support #578

Open
tristanguerragomez opened this issue Feb 28, 2024 · 2 comments
Open

CAN FD support #578

tristanguerragomez opened this issue Feb 28, 2024 · 2 comments

Comments

@tristanguerragomez
Copy link

CAN FD is rapidly becoming that de facto as it can provide much more bandwidth and is backwards compatible with CAN 2.0.

Are there any plans to update the API to support this scenario?

@reneherrero
Copy link

The fact that they moved the CAN code to a separate crate which is not at v1.0 might be indicative that changes are welcome?

Does anyone have any insight on this?

@liamkinne
Copy link
Contributor

I think there are two pathways to adding FD support:

  • Update the existing Frame trait doc-comments to specify that the DLC can be up to 15 and that message length can be up to 64 bytes, also adding other optional trait methods like is_brs for bitrate switching and the like.
  • Or, creating an separate trait FdFrame which implements the above.

I prefer the first method since it could be done without breaking existing uses of the Frame trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants