add optional defmt support for error types #76
Conversation
add defmt as an optional dependent package
|
I hope I did the CI part properly if not feel free to amend that... |
| @@ -19,6 +19,7 @@ pub type Result<T> = core::result::Result<T, Error>; | |||
| /// This type represents all possible errors that can occur when deserializing JSON data | |||
| #[derive(Debug, PartialEq, Eq, Clone)] | |||
| #[cfg_attr(not(feature = "custom-error-messages"), derive(Copy))] | |||
| #[cfg_attr(feature = "defmt", derive(defmt::Format))] | |||
There was a problem hiding this comment.
I think you need to add:
#[cfg_attr(feature = "defmt", defmt(defmt::Debug2Format))]above the heapless::String<64> error type.
There was a problem hiding this comment.
or adding "defmt-impl" feature into the heapless dependency
|
Is there anything here I can help with to get this merged? |
|
@vhdirk At this point, I would consider this PR abandoned. If you want to fork this current work and address my remaining comments, I'd be happy to review it as a separate PR :) |
|
@vhdirk if you can't do it, i can also help, tell me |
|
It's already being continued in #77 for now :) |
|
@vhdirk Thanks for picking up where I started with this and getting it in there! |
add defmt as an optional dependent package
I am only able to test defmt v0.3.0 as the rest of my project is using that version the latest is at v0.3.5
closes #75