-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🙋 Including rustc version in report #31
Comments
I'm not sure it's possible to get the version of the compiler a Rust binary was built with after compilation. At most we could try to include that statically in the binary. Running |
You might want to take a look at what build info the sentry crate gathers: https://github.com/getsentry/sentry-rust/blob/8dbda94b81b6efd92dfd9cfffb25414cffdaee17/build.rs |
Oh, interesting - looks like we could add a build script to this crate, and use https://crates.io/crates/rustc_version to include the version! Nice one @killercup. |
I'm working on integrating a similar build script into clippy right now, once that's done I'm happy to attempt the same here 👍 |
ping @phansch did you ever finish the build script so we can steal it? 🙂 |
Oh, I didn't end up doing it in the end and Clippy is available on stable now. I think using the It generates a |
Expected Behavior
I was investigating human-panic for possible usage in Clippy because we usually get a lot of failures due to being on nightly and depending on a lot of internal APIs.
Is there a possibility to include the current rustc version in the report?
Ideally, that would include everything that's shown in
rustc -vV
.Current Behavior
It's currently not included.
Possible Solution
I think executing
rustc -vV
, capturing the output and adding it to the report file should work, but not sure.I'd be happy to work on this if you have nothing against including that in the report.
The text was updated successfully, but these errors were encountered: