Remove wildcard re-exports #682
Conversation
|
ACK modulo CI |
|
Looks like CI is red because of formatting. |
tcharding
force-pushed
the
03-19-rm-wildcard
branch
from
8384783
to
863fd96
Compare
|
Ran the formatter, no other changes. |
|
Ah, sanitizers again :) |
|
EDIT: I just did #687 |
tcharding
force-pushed
the
03-19-rm-wildcard
branch
from
863fd96
to
9e1ec1a
Compare
|
No acks so rebasing to get up to date with master branch. |
|
So, in #656 we added a "check for changes to the public API" script but it looks like we have failed to CI-enforce this. Therefore this PR is unnecessarily hard to check. I think, for one, that you are losing a reexport of Can you open a PR to run the API script (there are a bunch of changes even on master) and to CI-check this, then rebase this PR on that? |
|
Yep sure thing. |
The `just` command makes scripts and commands discoverable for new devs and old devs alike when switching between repos. Add a justfile copied from bitcoin with changes as required.
Add a command to run the `contrib/check-for-api-changes.sh` script.
Run `just check-api` and commit the changes. We should have never gotten to this state, upcoming patch will check for changes in CI.
Add a job to run the `contrib/check-for-api-changes.sh` script in CI.
Copy the script from `rust-bitcoin`, also add a `just` command to call it.
tcharding
force-pushed
the
03-19-rm-wildcard
branch
from
9e1ec1a
to
1dc5bd2
Compare
|
Now on top of #691 |
Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit. Import and re-export explicitly instead of by using wildcards.
Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit. Re-export the `key` types explicitly.
tcharding
force-pushed
the
03-19-rm-wildcard
branch
from
1dc5bd2
to
0da394e
Compare
|
Awesome :). So much easier to review. I'm gonna try to ACK/merge this even though both Github and my local tools see it as 7 independent commits (even though 5 are already in master). I verified that the first 5 are exactly the same commits in #691. |
tcharding
dismissed
apoelstra’s stale review
The merge-base changed after approval.
Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit.
contexttypes explicitly.keytypes explicitly.Fix: #681