Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bitcoin dependency #39

Open
jrawsthorne opened this issue Aug 6, 2020 · 1 comment · May be fixed by #40
Open

Update bitcoin dependency #39

jrawsthorne opened this issue Aug 6, 2020 · 1 comment · May be fixed by #40

Comments

@jrawsthorne
Copy link
Contributor

Updating to the latest rust-bitcoin version brings some nice features such as the new hash types

In order to do this hammersbald needs to be updated (rust-bitcoin/hammersbald#13)

There also needs to be a decision about lightning.

  • The latest rust-lightning release was in April and doesn't use the latest version of bitcoin.
  • The module doesn't even compile currently
  • Most of the interfaces rust-lightning requires aren't provided by this library yet

I propose we remove the lightning module for now until the core functionality is finished
@TheBlueMatt
Copy link
Member

That seems fine to me, certainly anyone doing the work to maintain murmel can do whatever is easiest. rust-lightning will likely update to latest rust-bitcoin soon, we'll need to bump rust-secp and bitcoin_hashes as soon as a new release is cut either way.

@jrawsthorne jrawsthorne linked a pull request Aug 6, 2020 that will close this issue
Open
@stevenroose stevenroose mentioned this issue Feb 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade bitcoin version and remove lightning jrawsthorne/murmel
2 participants
@TheBlueMatt @jrawsthorne