Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss and sign off on error API #126

Open
tcharding opened this issue Nov 20, 2024 · 0 comments
Open

Discuss and sign off on error API #126

tcharding opened this issue Nov 20, 2024 · 0 comments
Labels
1.0 Issues and PRs required or helping to stabilize the API

Comments

@tcharding
Copy link
Member

tcharding commented Nov 20, 2024

Fix error APIs

ref: #43 (comment)

@Kixunil is not around at the moment and I do not know what is meant by this comment of his.

We want to 1.0 this crate, we should discuss and sign off on the error API.

Discussion should include:

IIRC, fully closing all the errors in this crate makes us have to duplicate the error types in rust-bitcoin. I did this at some stage in the past and it was a massive PITA. IMO we should just make a decision here and accept that we are stuck with it for 1.0

@tcharding tcharding added the 1.0 Issues and PRs required or helping to stabilize the API label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Issues and PRs required or helping to stabilize the API
Projects
None yet
Development

No branches or pull requests

1 participant