Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.0 release build failure #645

Closed
chenrui333 opened this issue Oct 10, 2023 · 7 comments
Closed

0.13.0 release build failure #645

chenrui333 opened this issue Oct 10, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@chenrui333
Copy link

👋 trying to build the latest release, but run into some build issue. The error log is as below:

error build log
  error[E0433]: failed to resolve: unresolved import
     --> crates/rune/src/languageserver/state.rs:271:36
      |
  271 |         let Ok(formatted) = crate::fmt::layout_source(&source) else {
      |                                    ^^^
      |                                    |
      |                                    unresolved import
      |                                    help: a similar path exists: `core::fmt`

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/6468976999/job/17562222470
relates to Homebrew/homebrew-core#150407

@udoprog udoprog added the bug Something isn't working label Oct 10, 2023
@udoprog
Copy link
Collaborator

udoprog commented Oct 10, 2023

Thanks!

Seems to be a feature unification issue when we only build with the languageserver feature.

I'm pushing a fix which tests that scenario in #646.

@udoprog
Copy link
Collaborator

udoprog commented Oct 10, 2023

0.13.1 is being shipped now, which hopefully contains a fix for this. Please verify!

@chenrui333
Copy link
Author

yeah, let me check now.

@chenrui333
Copy link
Author

works for me, thanks!

@chenrui333
Copy link
Author

chenrui333 commented Mar 7, 2024

@udoprog looks like the new tags did not get marked as releases, any reason why? Thanks!

image

relates to Homebrew/homebrew-core#165430

@udoprog
Copy link
Collaborator

udoprog commented Mar 7, 2024

Marking a release on Github is a manual process. I've done it now. Thanks!

@chenrui333
Copy link
Author

Great, thanks a lot for doing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants