Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fireEvent() should return false when inside Exception #113

Open
GoogleCodeExporter opened this issue Jul 27, 2015 · 1 comment
Open

fireEvent() should return false when inside Exception #113

GoogleCodeExporter opened this issue Jul 27, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

We have feedback in 
https://groups.google.com/forum/#!topic/mobicents-public/jr4cO2NP6Gg (messages 
from end of Aprel).
It looks like that - MAPResourceAdapter.fireEvent(String eventName, 
ActivityHandle handle, Object event, int flags)
should return false in case of Exception and true only if successed processing.

Original issue reported on code.google.com by [email protected] on 1 May 2015 at 5:17

@GoogleCodeExporter
Copy link
Author

I think we need to replace
try
{ sleeEndpoint.fireEvent(handle, eventID, event, address, null, flags); }
catch (UnrecognizedActivityHandleException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(IllegalEventException e) { this.tracer.severe("Error while firing event", e); }
catch (ActivityIsEndingException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(NullPointerException e) { this.tracer.severe("Error while firing event", e); }
catch (SLEEException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(FireEventException e) { this.tracer.severe("Error while firing event", e); }
return true;
with
} else {
try
{ sleeEndpoint.fireEvent(handle, eventID, event, address, null, flags); return 
true; }
catch (UnrecognizedActivityHandleException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(IllegalEventException e) { this.tracer.severe("Error while firing event", e); }
catch (ActivityIsEndingException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(NullPointerException e) { this.tracer.severe("Error while firing event", e); }
catch (SLEEException e)
{ this.tracer.severe("Error while firing event", e); } catch 
(FireEventException e) { this.tracer.severe("Error while firing event", e); }
return false;
}

Original comment by [email protected] on 1 May 2015 at 5:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant