Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package hashes are dependent on the engine_version of the current build #63

Open
rukai opened this issue Jul 29, 2018 · 0 comments
Open

Comments

@rukai
Copy link
Owner

rukai commented Jul 29, 2018

Package hashes depend on the engine version of the PF Sandbox running.
This makes sense and isn't something I want to change.
This doesn't affect netplay as netplay recalculates the hash and all clients need to be running the same PF Sandbox git commit anyway.
However this will affect the package quick checks for local tournament play.
People running newer version of PF Sandbox will have the hash check fail due to the json upgrade code changing the engine_version + whatever the required upgrade is.

Solution 1

Create a mechanism for the package source webserver to automatically update the package to the latest version.
However that the means the user should always be on the latest PF Sandbox or the package updates that get downloaded wont work.
This means I would also need some sort of mechanism for auto-updating PF Sandbox.
This would replace the builds page on the website: https://github.com/rukai/pf_sandbox_infra/blob/master/website/templates/builds.html.hbs

Solution 2

Provide hashes for each future engine_version the package is available for.
Might be easier to implement by git commits instead of engine_version but would be less efficient.
Will need to implement a package server to handle this though.
The package server will need to be able to run many PF Sandbox versions.

Solution 3

Simply tell the user why the package hash check is failing.
If the engine version is too old then tell the user which version of PF Sandbox they need to use OR that the check failed because they are using a newer version.
If the engine version is too new it wont even reach this point anyway.

@rukai rukai changed the title Package hashes are dependent on the version running. Package hashes are dependent on the engine_version of the current build Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant