Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed use of tabs.executeScript() and updated manifest files #147

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

tdulcet
Copy link
Contributor

@tdulcet tdulcet commented Oct 4, 2023

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is tested to still work?

@tdulcet
Copy link
Contributor Author

tdulcet commented Oct 6, 2023

Yes, I tested it and everything seems to work as before. Note that some minor CSS adjustments may be needed in your library: TinyWebEx/CommonCss#4. For example, I now see some "Times New Roman" font in the popup.

@rugk rugk merged commit 7dfb871 into rugk:main Oct 7, 2023
1 check failed
@rugk rugk deleted the mv3 branch October 7, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants