Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings not applied on Firefox sync #95

Open
rugk opened this issue Jun 4, 2020 · 1 comment
Open

Settings not applied on Firefox sync #95

rugk opened this issue Jun 4, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@rugk
Copy link
Owner

rugk commented Jun 4, 2020

Bug description

When a new setting is synced, it does not get automatically applied.

Steps to reproduce

  1. Disable colored icon on Device1.
  2. Sync Device1 with Device2. (e.g. by aadding/installing the add-on there)

Actual behavior

The emoji on Device2 is still colored (default setting).

Expected behavior

The emoji should be grayscale.

Workaround: Open the settings menu, it retriggers the activation.

System

Operating system and version: Fedora 32
Browser and version: Firefox 77
Add-on version: 2.0

Possible solution

Maybe we can add a trigger that runs "on Firefox sync" somehow? If the WebExtension API supports that…

May also affect other add-ons that use the same system.

Miscellaneous

This issue is reproducible on https://missive.github.io/emoji-mart/: N/A

@rugk rugk added the bug Something isn't working label Jun 4, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant