From c4038fc1b39001d797469c57e5a2ce54b253ad77 Mon Sep 17 00:00:00 2001 From: endy Date: Fri, 12 Jan 2018 16:17:06 +0500 Subject: [PATCH 1/5] fix(select-input): Add ignore errors if item prop is readonly --- .../src/controls/select-input/select-input.component.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libs/web/src/controls/select-input/select-input.component.ts b/libs/web/src/controls/select-input/select-input.component.ts index 86326fe5..6220e568 100644 --- a/libs/web/src/controls/select-input/select-input.component.ts +++ b/libs/web/src/controls/select-input/select-input.component.ts @@ -73,7 +73,12 @@ export class SelectInputComponent extends BaseComponent { return this.dataSource; } return this._items.map(item => { - item[this.inputTitleField] = this.getInputTitle(item); + // todo: refactor + try { + item[this.inputTitleField] = this.getInputTitle(item); + } catch (error) { + + } return item; }); } From 20d40e3682d0011a795cda367d756cd3ab4c3a48 Mon Sep 17 00:00:00 2001 From: endy Date: Fri, 12 Jan 2018 17:48:21 +0500 Subject: [PATCH 2/5] fix(navbar): Remove show changelog modal on first open site --- libs/web/src/controls/navbar/navbar.component.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/libs/web/src/controls/navbar/navbar.component.ts b/libs/web/src/controls/navbar/navbar.component.ts index 29e48d2a..d72773ed 100644 --- a/libs/web/src/controls/navbar/navbar.component.ts +++ b/libs/web/src/controls/navbar/navbar.component.ts @@ -107,7 +107,6 @@ export class NavbarComponent extends BaseComponent { } initVersion() { if (this.app.localVersion !== this.app.currentVersion) { - this.showChangeLog(); this.app.localVersion = this.app.currentVersion; } } From d70152a754bc53afc7060c1d5c54847b9b1eea6e Mon Sep 17 00:00:00 2001 From: endy Date: Fri, 12 Jan 2018 18:25:56 +0500 Subject: [PATCH 3/5] fix(base-resource-select-input): Set default value for inputReadonly to false --- .../base-resource-select-input.component.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libs/web/src/base/base-resources-grid/base-resource-select-input/base-resource-select-input.component.ts b/libs/web/src/base/base-resources-grid/base-resource-select-input/base-resource-select-input.component.ts index fcecf607..b0f5ea68 100644 --- a/libs/web/src/base/base-resources-grid/base-resource-select-input/base-resource-select-input.component.ts +++ b/libs/web/src/base/base-resources-grid/base-resource-select-input/base-resource-select-input.component.ts @@ -15,15 +15,15 @@ import { BaseResourcesListComponent } from '../base-resources-list/base-resource export class BaseResourceSelectInputComponent extends BaseResourcesListComponent { @Input() - labelClass?= 'control-label'; + labelClass = 'control-label'; @Input() - inputClass?= 'form-control'; + inputClass = 'form-control'; @Input() - inputFrameClass?= ''; + inputFrameClass = ''; @Input() - lookupTooltip?: string; + lookupTooltip: string; @Input() - lookupIcon?= 'fa fa-search'; + lookupIcon = 'fa fa-search'; @Input() readonly?: boolean; @Input() @@ -103,7 +103,7 @@ export class BaseResourceSelectInputComponent extends BaseResourcesListComponent this.hardReadonly = false; } if (this.inputReadonly === undefined) { - this.inputReadonly = true; + this.inputReadonly = false; } if (this.inputElement) { this.inputElement.hardValue = this.hardValue; From f2ab185abcba665ccd06d57d551f9527cb0856c1 Mon Sep 17 00:00:00 2001 From: endy Date: Fri, 12 Jan 2018 19:21:14 +0500 Subject: [PATCH 4/5] chore(components): Remove "?" symbol form props --- .../base-resource-input/base-resource-input.component.ts | 2 +- .../base-resources-list-modal.component.ts | 4 ++-- .../checkboxes-input/checkboxes-input.component.ts | 6 +++--- .../grid-row-buttons/grid-row-buttons.component.ts | 8 ++++---- .../src/controls/radios-input/radios-input.component.ts | 6 +++--- .../src/controls/select-input/select-input.component.ts | 8 ++++---- libs/web/src/controls/text-input/text-input.component.ts | 4 ++-- 7 files changed, 19 insertions(+), 19 deletions(-) diff --git a/libs/web/src/base/base-resources-grid/base-resource-input/base-resource-input.component.ts b/libs/web/src/base/base-resources-grid/base-resource-input/base-resource-input.component.ts index 64b143e8..5a8d0c46 100644 --- a/libs/web/src/base/base-resources-grid/base-resource-input/base-resource-input.component.ts +++ b/libs/web/src/base/base-resources-grid/base-resource-input/base-resource-input.component.ts @@ -15,7 +15,7 @@ export class BaseResourceInputComponent extends BaseComponent { @Input() lookupTooltip?: string; @Input() - lookupIcon?= 'fa fa-search'; + lookupIcon = 'fa fa-search'; @Input() readonly?: boolean; @Input() diff --git a/libs/web/src/base/base-resources-grid/base-resources-list-modal/base-resources-list-modal.component.ts b/libs/web/src/base/base-resources-grid/base-resources-list-modal/base-resources-list-modal.component.ts index 8af47c37..38e6a4ee 100644 --- a/libs/web/src/base/base-resources-grid/base-resources-list-modal/base-resources-list-modal.component.ts +++ b/libs/web/src/base/base-resources-grid/base-resources-list-modal/base-resources-list-modal.component.ts @@ -9,9 +9,9 @@ import { BaseModalComponent } from './../../base-modal/base-modal.component'; export class BaseResourceListModalComponent extends BaseModalComponent { @Input() - readonly?= false; + readonly = false; @Input() - hardReadonly?= false; + hardReadonly = false; item: any = {}; items: any[] = []; diff --git a/libs/web/src/controls/checkboxes-input/checkboxes-input.component.ts b/libs/web/src/controls/checkboxes-input/checkboxes-input.component.ts index 0c1ea063..fc080ef7 100644 --- a/libs/web/src/controls/checkboxes-input/checkboxes-input.component.ts +++ b/libs/web/src/controls/checkboxes-input/checkboxes-input.component.ts @@ -16,11 +16,11 @@ export class CheckboxesInputComponent extends BaseComponent { inputElement: ElementRef; @Input() - labelClass?= 'control-label'; + labelClass = 'control-label'; @Input() - inputClass?= 'control-label checkbox-inline'; + inputClass = 'control-label checkbox-inline'; @Input() - inputFrameClass?= 'form-control form-checkbox-controls'; + inputFrameClass = 'form-control form-checkbox-controls'; @Input() readonly = false; @Input() diff --git a/libs/web/src/controls/grid-row-buttons/grid-row-buttons.component.ts b/libs/web/src/controls/grid-row-buttons/grid-row-buttons.component.ts index 22b0e30a..7c5aabfa 100644 --- a/libs/web/src/controls/grid-row-buttons/grid-row-buttons.component.ts +++ b/libs/web/src/controls/grid-row-buttons/grid-row-buttons.component.ts @@ -15,13 +15,13 @@ export class GridRowButtonsComponent extends BaseComponent { @Input() removeTitle?: string; @Input() - editIcon?= 'fa fa-pencil-square-o'; + editIcon = 'fa fa-pencil-square-o'; @Input() - removeIcon?= 'fa fa-remove'; + removeIcon = 'fa fa-remove'; @Input() - editIconColor?= ''; // text-primary'; + editIconColor = ''; // text-primary'; @Input() - removeIconColor?= ''; // 'text-warning'; + removeIconColor = ''; // 'text-warning'; @Output() onEdit: EventEmitter = new EventEmitter(); @Output() diff --git a/libs/web/src/controls/radios-input/radios-input.component.ts b/libs/web/src/controls/radios-input/radios-input.component.ts index d0d3443b..7664a5c5 100644 --- a/libs/web/src/controls/radios-input/radios-input.component.ts +++ b/libs/web/src/controls/radios-input/radios-input.component.ts @@ -15,11 +15,11 @@ export class RadiosInputComponent extends BaseComponent { inputElement: ElementRef; @Input() - labelClass?= 'control-label'; + labelClass = 'control-label'; @Input() - inputClass?= 'control-label checkbox-inline'; + inputClass = 'control-label checkbox-inline'; @Input() - inputFrameClass?= 'form-control form-radio-controls'; + inputFrameClass = 'form-control form-radio-controls'; @Input() readonly = false; @Input() diff --git a/libs/web/src/controls/select-input/select-input.component.ts b/libs/web/src/controls/select-input/select-input.component.ts index 6220e568..bc1cd670 100644 --- a/libs/web/src/controls/select-input/select-input.component.ts +++ b/libs/web/src/controls/select-input/select-input.component.ts @@ -24,17 +24,17 @@ export class SelectInputComponent extends BaseComponent { inputElement: ElementRef; @Input() - debounceTime?: number; + debounceTime: number; @Output() onChangeInputValue: EventEmitter = new EventEmitter(); @Output() onInputFocus: EventEmitter = new EventEmitter(); @Input() - labelClass?= 'control-label'; + labelClass = 'control-label'; @Input() - inputClass?= 'form-control'; + inputClass = 'form-control'; @Input() - inputFrameClass?= ''; + inputFrameClass = ''; @Input() inFormGroup = true; @Input() diff --git a/libs/web/src/controls/text-input/text-input.component.ts b/libs/web/src/controls/text-input/text-input.component.ts index ff292ac9..46bd12eb 100644 --- a/libs/web/src/controls/text-input/text-input.component.ts +++ b/libs/web/src/controls/text-input/text-input.component.ts @@ -24,9 +24,9 @@ export class TextInputComponent extends BaseComponent { tooltip: TooltipDirective; @Input() - labelClass?= 'control-label'; + labelClass = 'control-label'; @Input() - inputClass?= 'form-control'; + inputClass = 'form-control'; @Input() inputFrameClass?: string; @Input() From ab80b2a95d0707e48d992fb8b98fcb17197cbf2d Mon Sep 17 00:00:00 2001 From: endy Date: Fri, 12 Jan 2018 19:57:04 +0500 Subject: [PATCH 5/5] chore(version): Release --- CHANGELOG.md | 12 ++++++++++++ apps/demo/src/index.html | 2 +- libs/core/src/package.json | 2 +- libs/web/src/package.json | 2 +- package-lock.json | 2 +- package.json | 2 +- 6 files changed, 17 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9576f470..1023e202 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,15 @@ + +## [1.30.1](https://github.com/rucken/core/compare/1.30.0...1.30.1) (2018-01-12) + + +### Bug Fixes + +* **base-resource-select-input:** Set default value for inputReadonly to false ([d70152a](https://github.com/rucken/core/commit/d70152a)) +* **navbar:** Remove show changelog modal on first open site ([20d40e3](https://github.com/rucken/core/commit/20d40e3)) +* **select-input:** Add ignore errors if item prop is readonly ([c4038fc](https://github.com/rucken/core/commit/c4038fc)) + + + # [1.30.0](https://github.com/rucken/core/compare/1.29.1...1.30.0) (2018-01-10) diff --git a/apps/demo/src/index.html b/apps/demo/src/index.html index 11afe349..4ee97a17 100644 --- a/apps/demo/src/index.html +++ b/apps/demo/src/index.html @@ -2,7 +2,7 @@ Rucken: Demo - + diff --git a/libs/core/src/package.json b/libs/core/src/package.json index 3bc85f03..fe3d8996 100644 --- a/libs/core/src/package.json +++ b/libs/core/src/package.json @@ -1,6 +1,6 @@ { "name": "@rucken/core", - "version": "1.30.0", + "version": "1.30.1", "description": "Core with base class and admin entities for application maked on Angular5+", "keywords": [ "ngx", diff --git a/libs/web/src/package.json b/libs/web/src/package.json index 19137aed..71257fb0 100644 --- a/libs/web/src/package.json +++ b/libs/web/src/package.json @@ -1,6 +1,6 @@ { "name": "@rucken/web", - "version": "1.30.0", + "version": "1.30.1", "description": "Base components, services and ui for admin entities for application maked on Angular5+", "keywords": [ "ngx", diff --git a/package-lock.json b/package-lock.json index 69026168..400a6d09 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "rucken", - "version": "1.30.0", + "version": "1.30.1", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 1642fd86..85c11a46 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "rucken", - "version": "1.30.0", + "version": "1.30.1", "license": "MIT", "author": "EndyKaufman ", "engines": {