Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow server pod Prometheus metrics to be enabled independently of creation of a ServiceMonitor #181

Closed
bjwhite-fnal opened this issue Feb 29, 2024 · 4 comments
Closed

Allow server pod Prometheus metrics to be enabled independently of creation of a ServiceMonitor #181

bjwhite-fnal opened this issue Feb 29, 2024 · 4 comments
Assignees
@bjwhite-fnal

Comments

@bjwhite-fnal
Copy link
Member

With the helm charts for the daemons it is possible to enable Prometheus metrics for a Pod independently of the ServiceMonitor prometheus-operator CRD.

The server is unable to make this distinction.
@bjwhite-fnal
Copy link
Member Author

@bari12 I'm not sure if you saw that I have a PR open for someone to look at: #182

@bari12
Copy link
Member

bari12 commented Mar 6, 2024

I saw, I was hoping that one of the helm-charts experts reviews this :-)

@bjwhite-fnal
Copy link
Member Author

Hey, @ericvaandering could you take a look at this?

@ericvaandering
Copy link
Contributor

I think this is going to be fine. I need to educate myself what a service monitor IS first.

@bari12 bari12 closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjwhite-fnal bjwhite-fnal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bari12 @ericvaandering @bjwhite-fnal