Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary requirements.txt fix from dev/Dockerfile #323

Open
rdimaio opened this issue Jun 10, 2024 · 1 comment · May be fixed by #358
Open

Remove temporary requirements.txt fix from dev/Dockerfile #323

rdimaio opened this issue Jun 10, 2024 · 1 comment · May be fixed by #358
Assignees
@rdimaio

Comments

@rdimaio
Copy link
Contributor

rdimaio commented Jun 10, 2024 •
edited
Loading

This issue tracks the temporary fix introduced in #324.

After the next major Rucio release, this temporary fix should be removed, and this issue can be closed.
@rdimaio rdimaio self-assigned this Jun 10, 2024
rdimaio added a commit to rdimaio/rucio-containers that referenced this issue Jun 10, 2024
@rdimaio
Dependencies: Temporarily accept either requirements.txt and requirem…
9f8d52f 
…ents.dev.txt in the dev container

As part of rucio/rucio#6750, we split
`requirements.txt` in `rucio/rucio` into separate requirements files,
depending on the application. We are keeping this change unreleased
until the next major Rucio release.

Until then, integration tests on `rucio/rucio:master` will use the new
`requirements.dev.txt` file, while the ones on `rucio/rucio:release-34`
will use the old `requirements.txt` file.

This commit is a temporary fix which will be removed after the next
major release. This issue will remain open until then: rucio#323
rdimaio added a commit to rdimaio/rucio-containers that referenced this issue Jun 10, 2024
@rdimaio
Dependencies: Temporarily accept either requirements.txt and requirem…
6cfc06a 
…ents.dev.txt in the dev container

As part of rucio/rucio#6750, we split
`requirements.txt` in `rucio/rucio` into separate requirements files,
depending on the application. We are keeping this change unreleased
until the next major Rucio release.

Until then, integration tests on `rucio/rucio:master` will use the new
`requirements.dev.txt` file, while the ones on `rucio/rucio:release-34`
will use the old `requirements.txt` file.

This commit is a temporary fix which will be removed after the next
major release. This issue will remain open until then: rucio#323
@rdimaio rdimaio mentioned this issue Jun 10, 2024
Merged
bari12 pushed a commit that referenced this issue Jun 10, 2024
@rdimaio @bari12
Dependencies: Temporarily accept either requirements.txt and requirem…
f92bc31 
…ents.dev.txt in the dev container

As part of rucio/rucio#6750, we split
`requirements.txt` in `rucio/rucio` into separate requirements files,
depending on the application. We are keeping this change unreleased
until the next major Rucio release.

Until then, integration tests on `rucio/rucio:master` will use the new
`requirements.dev.txt` file, while the ones on `rucio/rucio:release-34`
will use the old `requirements.txt` file.

This commit is a temporary fix which will be removed after the next
major release. This issue will remain open until then: #323
@rdimaio
Copy link
Contributor Author

rdimaio commented Nov 27, 2024

This is safe to be removed now. The only possible issue might be with the release-32-LTS tests, but we can backport the new requirements setup to that release instead (and we probably should anyway, since it'd let us pin dependencies for the LTS release too)

rdimaio added a commit to rdimaio/rucio-containers that referenced this issue Nov 27, 2024
@rdimaio
Dev: remove temporary workaround for old requirements format; fix ruc…
b8a8b5d 
…io#323
@rdimaio rdimaio linked a pull request Nov 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdimaio rdimaio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev: remove temporary workaround for old requirements format rdimaio/rucio-containers
1 participant
@rdimaio