-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying path to config file #303
Comments
A |
@postmodern glad you think so! I've got a PR open implementing this - let me know if you'd like any changes made :) |
Merged #306. Had to rebase and squash. |
Just to follow up: while that might be true, you can't pass an empty ignore (i.e I've left a comment on rails/thor#733 which I think would be the pathway to supporting this in Thor, which'd allow supporting that here by extension. |
It'd be nice to have a cli flag to allow pointing
bundler-audit
to an arbitrary config file, i.eMy use-case for this is that we have a central project auditor that runs against all of our projects and audits them with compatible tools (i.e if there's a
package-lock.json
it doesnpm audit
, if there's a Gemfile it doesbundle-audit
, if there's arequirements.txt
it doessafety
, etc).This tool is managed by our long-term app support team, so maintains its own ignore lists for each project independently of the projects themselves - this means for tools that support config files we explicitly ensure project-level versions of these files are not used when auditing (commonly by pointing at a blank version of that tools config).
Being able to provide an explicit path to the config would allow us to ensure this for
bundler-audit
, as well as let us maintain ignore lists for each app in their own file without any extra work (this is what we currently do for javascript auditing, since we useaudit-app
which supports a custom path).I've not yet played around with v0.8.0, so it's possible that
bundler-audit
ignores the ignores in the config file if you use the--ignore
flag, but there's a number of ways you could interpret having both the--ignore
flag + a config (i.e merging vs overriding; + what if I don't have any CVEs to ignore?)I'm happy to help implement this, but don't know when I'll have the time so opening an issue in-case others want to implement :)
The text was updated successfully, but these errors were encountered: