Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old thor version can cause errors from Ruby 2.5 #239

Closed
norbertszivos opened this issue Jan 3, 2020 · 2 comments
Closed

Old thor version can cause errors from Ruby 2.5 #239

norbertszivos opened this issue Jan 3, 2020 · 2 comments
Labels
dependencies Pull requests that update a dependency file duplicate

Comments

@norbertszivos
Copy link

We are using Rails 5.2.4 and Ruby 2.5.x and your awesome gem as well. After some gem updates the thor gem version was updated to 0.20.3 and when I try to run a rake command like bundle exec rake -T got this error: TypeError: NameErrorCheckers is not a module

After a long investigation I realised that the thor gem caused this because they start to support did_you_mean library. The problem is that this support is old and in the mean time the did_you_mean library was changed from
https://github.com/ruby/did_you_mean/blob/v1.1.3/lib/did_you_mean/spell_checkers/name_error_checkers.rb (this is using Ruby 2.4)
to
https://github.com/ruby/did_you_mean/blob/v1.2.0/lib/did_you_mean/spell_checkers/name_error_checkers.rb (this is using Ruby 2.5)

The thor gem was updated so version 1.x can solve the issue, but your gem does not let us to update this gem. The thor gem should stay on 0.20.0 because of that.

Could you update your thor support, please?
@joshRpowell
Copy link

see #237

mike-burns added a commit to thoughtbot/suspenders that referenced this issue Apr 24, 2020
@mike-burns
bundler-audit 0.7.0
673fc8c 
Use bundler-audit 0.7.0, currently in pre-release. It has an
up-to-date Thor dependency, which fixes an incompatibility with Bundler
2.

Here is a trail of bug reports and fixes against the repo:

* <rubysec/bundler-audit#239>
* <rubysec/bundler-audit#237>
* <rubysec/bundler-audit#252>
mike-burns added a commit to thoughtbot/suspenders that referenced this issue Apr 24, 2020
@mike-burns
bundler-audit 0.7.0
9371e60 
Use bundler-audit 0.7.0, currently in pre-release. It has an
up-to-date Thor dependency, which fixes an incompatibility with Bundler
2.

Here is a trail of bug reports and fixes against the repo:

* <rubysec/bundler-audit#239>
* <rubysec/bundler-audit#237>
* <rubysec/bundler-audit#252>
mike-burns added a commit to thoughtbot/suspenders that referenced this issue Apr 24, 2020
@mike-burns
bundler-audit 0.7.0
db889d3 
Use bundler-audit 0.7.0, currently in pre-release. It has an
up-to-date Thor dependency, which fixes an incompatibility with Bundler
2.

Here is a trail of bug reports and fixes against the repo:

* <rubysec/bundler-audit#239>
* <rubysec/bundler-audit#237>
* <rubysec/bundler-audit#252>
mike-burns added a commit to thoughtbot/suspenders that referenced this issue Apr 24, 2020
@mike-burns
bundler-audit 0.7.0
b1d02e7 
Use bundler-audit 0.7.0, currently in pre-release. It has an
up-to-date Thor dependency, which fixes an incompatibility with Bundler
2.

Here is a trail of bug reports and fixes against the repo:

* <rubysec/bundler-audit#239>
* <rubysec/bundler-audit#237>
* <rubysec/bundler-audit#252>
@postmodern
Copy link
Member

bundler-audit updated the thor dependency to >= 0.18, < 2.

@postmodern postmodern added duplicate dependencies Pull requests that update a dependency file labels Dec 17, 2020
Web-Go-To added a commit to Web-Go-To/rails_suspenders that referenced this issue Mar 23, 2023
@Web-Go-To
bundler-audit 0.7.0
93d30c6 
Use bundler-audit 0.7.0, currently in pre-release. It has an
up-to-date Thor dependency, which fixes an incompatibility with Bundler
2.

Here is a trail of bug reports and fixes against the repo:

* <rubysec/bundler-audit#239>
* <rubysec/bundler-audit#237>
* <rubysec/bundler-audit#252>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@postmodern @norbertszivos @joshRpowell