Add indicator fields to partner export

[Sukhpreet-s]

Partial #3067

Description

This PR adds 2 new columns, at the end of existing columns, in the partner export file:

1. Providing Diapers: "Y" or "N", depending if the partner has at least one distribution (in the last 12 months) with an item of scope :disposable or :cloth_diapers.
2. Providing Period Supplies: "Y" or "N", depending if the partner has at least one distribution (in the last 12 months) with an item of scope :period_supplies.

Note

The criteria for finding whether a Partner has been provided with "Diapers" is if the Partner has at least one distribution with an item of either :disposable OR :cloth_diapers scope, OR both scopes.

Note

The filter for finding distributions within the last 12 months is based on issued_at attribute of Distribution model.

Example:

Providing Diapers	Providing Period Supplies
N	N
Y	Y
Y	Y
Y	N
N	N
N	N
Y	Y

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually and added test cases for:

1. Adding both columns in the right place/order
2. If a partner has a distribution with a :disposable item, then it should have "Y" for the Providing Diapers column.
3. If a partner has a distribution with a :cloth_diapers item, then it should have "Y" for the Providing Diapers column.
4. If a partner has a distribution with a :period_supplies item, then it should have "Y" for the Providing Period Supplies column.
5. If a partner has a distribution with items satisfying all the above scopes (:disposable, :cloth_diapers, and :period_supplies) but the distribution is older than 12 months, then it should have "N" for both Providing Diapers and Providing Period Supplies columns.

[cielf]

Hey @Sukhpreet-s Taking a very quick look at this (not yet a real review), I think you missed a point in the requirements:

"Based on discussions with the stakeholder circle, the "Providing Period Supplies" and "Providing Diapers" should be based on whether there have been distributions with period supplies or with diapers in the last 12 months."

The main purpose for this indicator is to support annual reporting in January, so the idea of whether the partner is "currently" being supplied is what we're getting at. I do expect that 98 times out of 100, these will be the same in the wild

[cielf]

@dorner -- just a note that there will almost certainly be conflicts between this and #4840.

[Sukhpreet-s]

👋 @cielf, I’ve updated the indicator logic to ensure it only uses distributions from the last 12 months. When you have a moment, could you please take a quick look to confirm if this aligns with the requirements? Your feedback would be greatly appreciated. 🙏 Thank you! 😊

[cielf]

Was working with wrong version for this. Retesting.

Was working with wrong version.

[cielf]

Passes manual testing (after I brought down the right version!) I noticed one thing in the tests regarding the date of the distribution that should fail, but otherwise over to @dorner for technical comments.

[dorner]

@Sukhpreet-s looks good to me, but there's now a conflict. Can you fix please?