Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4175 add request type flag #4827

Merged
merged 51 commits into from
Dec 10, 2024
Merged

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Dec 4, 2024

==================================

Continuation of PR #4271. i tried to add commits directly on that PR, but I think the owner's fork of the repo has been deleted, so I'm creating a new PR but with all previous commits intact.

==================================

Resolves #4175

Description

Adds a request type flag to index and show pages as well as to the downloadable document so that banks can better see which type of request is being made.

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots (Updated)

Screenshot from 2024-12-04 12-56-25
I made it so that you can hover over the request type initial for the full name of the request type in the index page. (Can remove if unwanted.)

Screenshot from 2024-12-04 12-58-33

Requests-2024-12-04 (1).csv

nathangthomas and others added 30 commits March 15, 2024 13:31
…s export. Adds filter by request type to index.
…s export. Adds filter by request type to index.
…in view to display only the first letter, pull request_type from service instead of defining with an instance var.
@coalest coalest requested review from dorner and cielf December 4, 2024 12:10
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality still checks out.

Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@dorner dorner merged commit b761496 into rubyforgood:main Dec 10, 2024
11 checks passed
@coalest coalest deleted the 4175-add-request-type-flag branch December 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flag that is the type of request.
4 participants