You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't do a great job at showing empty states in the app. We show them sometimes, and other times not. The task in this issue is to implement a single empty state partial. Given most of our empty states are used with filters, we can have default text in the partial like 'No results matching your search criteria', and to handle other cases, e.g., 'You have no liked pets', we can pass the string we want to display, and if provided, show that instead.
Please place this partial somewhere top level because it will be used throughout the app, e.g., app/views/shared and then update all places we should use an empty state.
Off the top of my head, this includes
Staff > pets, adoption applications, fosters, default pet tasks (where we use filters)
click around and see if you can find another place...but I think that's it?
We have some places that display an empty state in a table (like adopter fosterer > adoption applications, or Staff > Pet photos/attachments). It might make sense to leave these as is and not use the new partial. You can be final judge of that.
The text was updated successfully, but these errors were encountered:
@kasugaijin In the existing code I'm seeing places where i18n is used through the config/locales/en.yml file. There are some places where i18n isn't used though. What is the preference here?
@jp524 please use translations and structure them for lazy look up where possible. Technically all our view copy should come from a translation file…there’s a few spots that have not been updated yet.
We don't do a great job at showing empty states in the app. We show them sometimes, and other times not. The task in this issue is to implement a single empty state partial. Given most of our empty states are used with filters, we can have default text in the partial like 'No results matching your search criteria', and to handle other cases, e.g., 'You have no liked pets', we can pass the string we want to display, and if provided, show that instead.
Please place this partial somewhere top level because it will be used throughout the app, e.g.,
app/views/shared
and then update all places we should use an empty state.Off the top of my head, this includes
We have some places that display an empty state in a table (like adopter fosterer > adoption applications, or Staff > Pet photos/attachments). It might make sense to leave these as is and not use the new partial. You can be final judge of that.
The text was updated successfully, but these errors were encountered: