Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Pets: improvements #1198

Open
kasugaijin opened this issue Nov 29, 2024 · 4 comments
Open

Featured Pets: improvements #1198

kasugaijin opened this issue Nov 29, 2024 · 4 comments
Assignees

Comments

@kasugaijin
Copy link
Collaborator

kasugaijin commented Nov 29, 2024

On the org home page, we see some feature pets. Let's improve this:

  • this section should render conditionally, and only show if the collection of pets passed to the view is not empty
  • if you look at the controller, the @pets collection query should be improved. The collection is set using a sample of 4, but this fails when the available pets is less than 4, because it starts to duplicate. So, I think we need a check there to see if the total number of adoptable pets is greater than 4, then sample 4, otherwise, return all pets (could be 1, 2, or 3 in total). Note, we do not need this line in the query .where(organization: Current.organization) because all Pet queries in this controller scope are already scoped to the tenant. Finally please use the Pet.unadopted scope to only return adoptable pets.
  • try uploading images of different sizes and you will see the cards end up being slightly different heights based on the uploaded image, so please enforce a consistent height for all images that display in the cards

Example of different height images, that should be the same height
image

@kasugaijin kasugaijin added the Ready Make a comment to get assigned. label Nov 29, 2024
@Aaryanpal
Copy link
Contributor

@kasugaijin please assgin!

@kasugaijin kasugaijin removed the Ready Make a comment to get assigned. label Dec 1, 2024
@kasugaijin
Copy link
Collaborator Author

@Aaryanpal how's this going?

@Aaryanpal
Copy link
Contributor

@kasugaijin haven't started it yet.
will get it done by this weekend.

@kasugaijin
Copy link
Collaborator Author

kasugaijin commented Dec 10, 2024

@Aaryanpal awesome thanks for the update !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants