fill CHANGELOG/README for implemented Ferrum::Browser#wait_for_select…

…or method
rubycdp · Jan 15, 2022 · 3b09739 · 3b09739
1 parent cf74591
commit 3b09739
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ### Added
 
+- `Ferrum::Browser#wait_for_selector`: returns instance of `Ferrum::Node` that's matched by provided selector.
 - Alias `Ferrum::Frame#content=` to `Ferrum::Frame#set_content`
 - Alias `Ferrum::Node#propery` to `Ferrum::Node#[]`
 - Implement `Ferrum::Network#blacklist=` and `Ferrum::Network#whitelist=`

diff --git a/README.md b/README.md
@@ -343,6 +343,18 @@ browser.go_to("https://google.com/")
 browser.body # => '<html itemscope="" itemtype="http://schema.org/WebPage" lang="ru"><head>...
 ```
 
+#### wait_for_selector : `Node`
+
+```ruby
+browser.wait_for_selector(css: "body", timeout: 5000) # => [Node]
+browser.wait_for_selector(xpath: "//body", interval: 200) # => [Node]
+```
+
+* options `Hash`
+  * `:css` (String) - selector in css format, not specified by default.
+  * `:xpath` (String) - selector in xpath format, not specified by default.
+  * `:timeout` (Integer) - timeout for the selector-waiting in milliseconds, 3000 ms by default.
+  * `:interval` (Integer) - interval that used to compute attempts for the selector-waiting (max attempts = timeout / interval), 100 by default.
 
 ## Screenshots
 

diff --git a/lib/ferrum/frame/dom.rb b/lib/ferrum/frame/dom.rb
@@ -46,8 +46,7 @@ def wait_for_selector(css: nil, xpath: nil, timeout: 3000, interval: 100)
                 return reject(new Error("Not found element match the selector: " + selector));
               }
               var element = isXpath
-                ? document.
-                  evaluate(selector, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue
+                ? document.evaluate(selector, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue
                 : document.querySelector(selector);
               if (element !== null) {
                 return resolve(element);